Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(india): eway bill cancel api is disabled #31055

Conversation

maharshivpatel
Copy link
Contributor

@maharshivpatel maharshivpatel commented May 17, 2022

E-invoice API for E-way bill cancellation from Adaequare is permanently disabled on their production API.

I had tested their API on staging and it was working fine. I had also checked their API documentation and everything suggested that it was available. Still, it gives a 404 error on production API so I contacted them and after discussion, they have told me that it is disabled on production API and will not be available user will have to cancel it from the e-way bill portal.

I have removed the changes made by #30888 that enabled the cancel API.

@nextchamp-saqib API URL for cancelation https://gsp.adaequare.com/enriched/ewb/ewayapi?action=CANEWB will only work if the user has purchased their e-way bill API Package.

There is no need for the cancel_eway_bill function anymore but I have not removed it.

E-invoice API for E-way bill cancellation from Adaequare is permanently disabled on their production API.
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #31055 (b9da04b) into develop (28fe4f3) will decrease coverage by 0.09%.
The diff coverage is 20.00%.

@@             Coverage Diff             @@
##           develop   #31055      +/-   ##
===========================================
- Coverage    63.09%   62.99%   -0.10%     
===========================================
  Files          985      985              
  Lines        67280    67281       +1     
===========================================
- Hits         42451    42387      -64     
- Misses       24829    24894      +65     
Impacted Files Coverage Δ
erpnext/regional/india/e_invoice/utils.py 40.37% <20.00%> (-0.06%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 81.96% <0.00%> (-8.20%) ⬇️
...unts/report/purchase_register/purchase_register.py 71.71% <0.00%> (-6.58%) ⬇️
erpnext/accounts/party.py 78.09% <0.00%> (-4.62%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 74.25% <0.00%> (-3.97%) ⬇️
.../fifo_queue_vs_qty_after_transaction_comparison.py 93.10% <0.00%> (-1.73%) ⬇️
erpnext/stock/reorder_item.py 75.21% <0.00%> (-1.71%) ⬇️
... and 19 more

@nextchamp-saqib nextchamp-saqib changed the title Critical-fix Eway Bill Cancel Api is Disabled fix(india): eway bill cancel api is disabled May 18, 2022
@nextchamp-saqib nextchamp-saqib added backport version-13-hotfix and removed needs-tests This PR needs automated unit-tests. labels May 18, 2022
@nextchamp-saqib nextchamp-saqib merged commit 65d55ea into frappe:develop May 18, 2022
mergify bot pushed a commit that referenced this pull request May 18, 2022
hrwX pushed a commit to hrwX/erpnext that referenced this pull request May 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants